Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests for Item client methods #119

Merged
merged 38 commits into from
Feb 9, 2021
Merged

Refactor and add tests for Item client methods #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
6904611
return exported errors
joe94 Feb 2, 2021
3808402
unit test for validateConfig
joe94 Feb 2, 2021
70252bb
i/o structs for GetItems + helper make/do funcs
joe94 Feb 2, 2021
c220ce1
add test for do function
joe94 Feb 2, 2021
c9a81c4
add makeRequest tests
joe94 Feb 3, 2021
1629e66
Fix some typos
joe94 Feb 3, 2021
b39cc98
cover obvious cases for client.do
joe94 Feb 3, 2021
d22fd43
Test GetItems
joe94 Feb 3, 2021
2b70aa7
try new name for file
joe94 Feb 3, 2021
0f0064b
Update pushItem method
joe94 Feb 3, 2021
4cf9492
Add PushItem test
joe94 Feb 3, 2021
42bf0c9
Update removeItem method
joe94 Feb 4, 2021
d7d238e
add removeItem tests
joe94 Feb 4, 2021
5bf2a70
minor reformat and clean up in test file
joe94 Feb 4, 2021
b84cfa3
Move helper struct up in the file
joe94 Feb 4, 2021
d0746ca
Add missing test case
joe94 Feb 4, 2021
94c6f45
Update existing code
joe94 Feb 4, 2021
c836bd5
Add comments to exported param structs
joe94 Feb 4, 2021
df97c2e
Add disclaimer note
joe94 Feb 4, 2021
34ac37d
fix linter errors and add missing test assertions
joe94 Feb 4, 2021
5891bca
add release notes
joe94 Feb 4, 2021
543bcec
fix missing errorf statement
joe94 Feb 5, 2021
ef5ae75
clean up old values
joe94 Feb 5, 2021
83d7eda
Update chrysom/client.go
joe94 Feb 5, 2021
a4b953c
add changes from code review
joe94 Feb 6, 2021
406d6ae
Merge branch 'feature/betterTesting' of github.com:xmidt-org/argus in…
joe94 Feb 8, 2021
29e3851
Merge make request and do helper funcs
joe94 Feb 8, 2021
3293bcc
Update code around GetItems
joe94 Feb 8, 2021
ae98d19
update getItems test
joe94 Feb 8, 2021
a8f6431
update pushItem
joe94 Feb 8, 2021
a509abd
Update removeItem
joe94 Feb 8, 2021
a6e56ee
revert start signature
joe94 Feb 8, 2021
32df96e
more clean up and updates
joe94 Feb 8, 2021
8e37bf1
minor clean up and standardize naming
joe94 Feb 8, 2021
9b0cf38
make some errors internal
joe94 Feb 8, 2021
64510bf
improve error handling/reporting
joe94 Feb 8, 2021
1e6f0c3
fix linting warnings
joe94 Feb 9, 2021
6198207
linting fix
joe94 Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Add bucket validation. [#114](https://github.com/xmidt-org/argus/pull/114)
- Remove stored loggers. [#118](https://github.com/xmidt-org/argus/pull/118)
- Drop use of admin token headers from client. [#118](https://github.com/xmidt-org/argus/pull/118)
- Refactor client code and add unit tests around item CRUD operations [#119](https://github.com/xmidt-org/argus/pull/119)

### Fixed
- Fix behavior in which the owner of an existing item was overwritten in super user mode. [#116](https://github.com/xmidt-org/argus/pull/116)
Expand Down
Loading