Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use trace context in outgoing http request #176

Merged
merged 2 commits into from
May 19, 2021
Merged

use trace context in outgoing http request #176

merged 2 commits into from
May 19, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented May 19, 2021

Fix needed to resolve xmidt-org/tr1d1um#210

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #176 (4583ec9) into main (2d99e76) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   63.24%   63.24%           
=======================================
  Files          16       16           
  Lines         876      876           
=======================================
  Hits          554      554           
  Misses        306      306           
  Partials       16       16           
Impacted Files Coverage Δ
chrysom/client.go 90.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d99e76...4583ec9. Read the comment docs.

@joe94 joe94 force-pushed the bugfix/contextTrace branch from 2e8d6fe to 4583ec9 Compare May 19, 2021 20:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit 5f03801 into main May 19, 2021
@joe94 joe94 deleted the bugfix/contextTrace branch May 19, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tr1d1um is not forwarding the TraceInformation to downstream services.
1 participant