Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/zap logging #185

Merged
merged 9 commits into from
Jun 4, 2021
Merged

Feature/zap logging #185

merged 9 commits into from
Jun 4, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 4, 2021

Adding arrange and zap logger to Argus 😎
I didn't update the bascule getters and setters yet as I plan to do that as part of #183

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #185 (789de53) into main (b9b8c09) will increase coverage by 0.07%.
The diff coverage is 0.00%.

❗ Current head 789de53 differs from pull request most recent head fdc3b6b. Consider uploading reports for the commit fdc3b6b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   63.24%   63.31%   +0.07%     
==========================================
  Files          16       16              
  Lines         876      875       -1     
==========================================
  Hits          554      554              
+ Misses        306      305       -1     
  Partials       16       16              
Impacted Files Coverage Δ
store/cassandra/db.go 0.00% <0.00%> (ø)
store/cassandra/executer.go 0.00% <0.00%> (ø)
store/dynamodb/db.go 33.33% <0.00%> (ø)
store/dynamodb/service.go 84.74% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b8c09...fdc3b6b. Read the comment docs.

@joe94 joe94 requested a review from kristinapathak June 4, 2021 01:23
@joe94 joe94 linked an issue Jun 4, 2021 that may be closed by this pull request
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@joe94 joe94 merged commit c2562df into main Jun 4, 2021
@joe94 joe94 deleted the feature/zapLogging branch June 4, 2021 21:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to zap logger
2 participants