Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify comments about default item owner value #202

Merged
merged 3 commits into from
Sep 20, 2021
Merged

clarify comments about default item owner value #202

merged 3 commits into from
Sep 20, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Sep 16, 2021

No description provided.

@joe94 joe94 linked an issue Sep 16, 2021 that may be closed by this pull request
Documentation: storing an item without a x-midt-owner will prevent overwriting with a request with an owner #166
Closed
@codecov
Copy link

codecov bot commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #202 (191bf5b) into main (90e33a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   62.66%   62.66%           
=======================================
  Files          16       16           
  Lines        1074     1074           
=======================================
  Hits          673      673           
  Misses        384      384           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e33a1...191bf5b. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@joe94 joe94 requested a review from JC000 September 20, 2021 20:30
JC000
JC000 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@JC000 JC000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JC000 JC000 merged commit 47258e3 into main Sep 20, 2021
@JC000 JC000 deleted the feature/docUpdate branch September 20, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JC000 JC000 JC000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: storing an item without a x-midt-owner will prevent overwriting with a request with an owner
2 participants
@joe94 @JC000