Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply auth only on supported routes #21

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Apply auth only on supported routes #21

merged 2 commits into from
Aug 7, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Aug 7, 2020

No description provided.

@joe94 joe94 self-assigned this Aug 7, 2020
@joe94 joe94 added the bug Something isn't working label Aug 7, 2020
@joe94 joe94 requested a review from kcajmagic August 7, 2020 20:30
@codecov
Copy link

codecov bot commented Aug 7, 2020 •
edited
Loading

Codecov Report

Merging #21 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   12.05%   12.05%           
=======================================
  Files          12       12           
  Lines         788      788           
=======================================
  Hits           95       95           
  Misses        673      673           
  Partials       20       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0524495...5a6e0aa. Read the comment docs.

@kcajmagic
Copy link
Member

Closes #19

@kcajmagic kcajmagic linked an issue Aug 7, 2020 that may be closed by this pull request
argus returns 403 instead of 404 from non-existent endpoint #19
Closed
@joe94 joe94 merged commit 1a569fb into main Aug 7, 2020
@joe94 joe94 deleted the bugfix/routeBeforeAuth branch August 7, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

Assignees

@joe94 joe94

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argus returns 403 instead of 404 from non-existent endpoint
2 participants
@joe94 @kcajmagic