Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed ID to be case sensitive #227

Merged
merged 2 commits into from
Feb 23, 2022
Merged

changed ID to be case sensitive #227

merged 2 commits into from
Feb 23, 2022

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented Feb 23, 2022 •
edited
Loading

fixes #226

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #227 (233b238) into main (b8b6713) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   62.62%   62.52%   -0.11%     
==========================================
  Files          18       18              
  Lines        1097     1094       -3     
==========================================
- Hits          687      684       -3     
  Misses        388      388              
  Partials       22       22
Impacted Files Coverage Δ
store/inputValidation.go 95.12% <ø> (-0.34%) ⬇️
store/transport.go 92.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8b6713...233b238. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak marked this pull request as ready for review February 23, 2022 20:24
@kristinapathak kristinapathak merged commit 9e30f67 into main Feb 23, 2022
@kristinapathak kristinapathak deleted the case-sensitive-id branch February 23, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

id is only partly case insensitve
2 participants
@kristinapathak @kcajmagic