Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamodb: updated get all query and added configurable limit #230

Merged
merged 5 commits into from
Apr 12, 2022

Conversation

kristinapathak
Copy link
Contributor

fixes #229

@kristinapathak kristinapathak added the bug Something isn't working label Apr 5, 2022
@kristinapathak kristinapathak requested a review from kcajmagic April 5, 2022 02:32
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #230 (fd60335) into main (d987861) will increase coverage by 0.17%.
The diff coverage is 60.86%.

❗ Current head fd60335 differs from pull request most recent head 2ec1bbb. Consider uploading reports for the commit 2ec1bbb to get more accurate results

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
+ Coverage   62.87%   63.04%   +0.17%     
==========================================
  Files          18       18              
  Lines        1099     1115      +16     
==========================================
+ Hits          691      703      +12     
- Misses        387      391       +4     
  Partials       21       21              
Impacted Files Coverage Δ
store/dynamodb/db.go 46.80% <0.00%> (ø)
store/dynamodb/service.go 83.91% <63.63%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d987861...2ec1bbb. Read the comment docs.

Copy link
Member

@kcajmagic kcajmagic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Took me awhile to think through the gauge metric, good use.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

@kristinapathak kristinapathak merged commit 2a17eda into main Apr 12, 2022
@kristinapathak kristinapathak deleted the get-all-limit branch April 12, 2022 23:27
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.2% 76.2% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configurable limit for GetAll db requests
3 participants