Argus 237

CHANGELOG.md

@@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+- [Incomplete log error message #237](https://github.com/xmidt-org/argus/issues/237)
 
 ## [v0.9.9]
 - Update bascule config for docker [#433]](https://github.com/xmidt-org/argus/pull/433)

argus.yaml

@@ -12,8 +12,9 @@ logging:
   level: debug
   development: true
   encoderConfig:
-    messageKey: msg
-    levelKey: level
+    messageKey: message
+    levelKey: key
+    levelEncoder: lowercase
 
 health:
   disableLogging: false

store/errors.go

@@ -11,15 +11,15 @@ import (
 
 // Sentinel internal errors.
 var (
-	ErrItemNotFound   = errors.New("Item at resource path not found")
-	ErrJSONDecode     = errors.New("Error decoding JSON data from DB")
-	ErrJSONEncode     = errors.New("Error encoding JSON data to send to DB")
-	ErrQueryExecution = errors.New("Error occurred during DB query execution")
+	ErrItemNotFound   = errors.New("item at resource path not found")
+	ErrJSONDecode     = errors.New("error decoding JSON data from DB")
+	ErrJSONEncode     = errors.New("error encoding JSON data to send to DB")
+	ErrQueryExecution = errors.New("error occurred during DB query execution")
 )
 
 // Sentinel errors to be used by the HTTP response error encoder.
 var (
-	ErrHTTPItemNotFound = &erraux.Error{Err: errors.New("Item not found"), Code: http.StatusNotFound}
+	ErrHTTPItemNotFound = &erraux.Error{Err: errors.New("item not found"), Code: http.StatusNotFound}
 	ErrHTTPOpFailed     = &erraux.Error{Err: errors.New("DB operation failed"), Code: http.StatusInternalServerError}
 )
 

store/provide.go

@@ -117,14 +117,14 @@ func buildInputRegexValidators(userInputValidation UserInputValidationConfig, co
 	bucketFormatRegex := useOrDefault(userInputValidation.BucketFormatRegex, BucketFormatRegexSource)
 	bucketRegex, err := regexp.Compile(bucketFormatRegex)
 	if err != nil {
-		return fmt.Errorf("Bucket %w: %v", errRegexCompilation, err)
+		return fmt.Errorf("bucket %w: %v", errRegexCompilation, err)
 	}
 	config.BucketFormatRegex = bucketRegex
 
 	ownerFormatRegex := useOrDefault(userInputValidation.OwnerFormatRegex, OwnerFormatRegexSource)
 	ownerRegex, err := regexp.Compile(ownerFormatRegex)
 	if err != nil {
-		return fmt.Errorf("Owner %w: %v", errRegexCompilation, err)
+		return fmt.Errorf("owner %w: %v", errRegexCompilation, err)
 	}
 	config.OwnerFormatRegex = ownerRegex
 

store/transport.go

@@ -236,7 +236,7 @@ func encodeError(getLogger func(context.Context) *zap.Logger) kithttp.ErrorEncod
 
 		logger := getLogger(ctx)
 		if logger != nil && code != http.StatusNotFound {
-			logger.Error("sending non-200, non-404 response", zap.Error(err), zap.Int("statusCode", code))
+			logger.Error("sending non-200, non-404 response", zap.Error(err), zap.Int("code", code))
 		}
 
 		w.WriteHeader(code)