Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/get all #53

Merged
merged 7 commits into from
Sep 23, 2020
Merged

Feature/get all #53

merged 7 commits into from
Sep 23, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Sep 22, 2020

No description provided.

@joe94 joe94 marked this pull request as draft September 22, 2020 22:07
@joe94 joe94 self-assigned this Sep 22, 2020
@joe94 joe94 added the enhancement improvement or small functionality added to an existing feature label Sep 22, 2020
@joe94 joe94 linked an issue Sep 22, 2020 that may be closed by this pull request
Add helper functions for GetAllItems handler #48
Closed
@joe94 joe94 marked this pull request as ready for review September 22, 2020 23:08
@joe94 joe94 changed the base branch from feature/deleteItem to main September 23, 2020 18:02
@codecov
Copy link

codecov bot commented Sep 23, 2020 •
edited
Loading

Codecov Report

Merging #53 into main will increase coverage by 1.95%.
The diff coverage is 74.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   25.74%   27.69%   +1.95%     
==========================================
  Files          14       14              
  Lines         738      769      +31     
==========================================
+ Hits          190      213      +23     
- Misses        531      538       +7     
- Partials       17       18       +1
Impacted Files Coverage Δ
store/handler.go 0.00% <0.00%> (ø)
store/transport.go 78.84% <89.47%> (+6.11%) ⬆️
store/endpoint.go 32.09% <100.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9060cd6...b342799. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

78.1% 78.1% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit fc293ea into main Sep 23, 2020
@joe94 joe94 deleted the feature/getAll branch September 25, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

@kristinapathak kristinapathak Awaiting requested review from kristinapathak

Assignees

@joe94 joe94

Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helper functions for GetAllItems handler
2 participants
@joe94 @kcajmagic