Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using newly created Handlers #56

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Switch to using newly created Handlers #56

merged 4 commits into from
Sep 29, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Sep 26, 2020

No description provided.

@joe94 joe94 added the enhancement improvement or small functionality added to an existing feature label Sep 26, 2020
@codecov
Copy link

codecov bot commented Sep 26, 2020 •
edited
Loading

Codecov Report

Merging #56 into main will increase coverage by 6.19%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   30.93%   37.13%   +6.19%     
==========================================
  Files          14       14              
  Lines         821      684     -137     
==========================================
  Hits          254      254              
+ Misses        547      410     -137     
  Partials       20       20
Impacted Files Coverage Δ
store/errors.go 0.00% <0.00%> (ø)
store/handler.go 0.00% <ø> (ø)
store/provide.go 0.00% <0.00%> (ø)
store/store.go 100.00% <ø> (ø)
store/endpoint.go 100.00% <100.00%> (+61.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 530c07c...f5c90b9. Read the comment docs.

@joe94 joe94 linked an issue Sep 26, 2020 that may be closed by this pull request
Switch to using refactored handlers #57
Closed
@joe94 joe94 requested a review from kcajmagic September 26, 2020 00:39
@joe94 joe94 self-assigned this Sep 26, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

4.0% 4.0% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit 22b3c6d into main Sep 29, 2020
@joe94 joe94 deleted the feature/switchHandlers branch September 29, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcajmagic kcajmagic kcajmagic approved these changes

Assignees

@joe94 joe94

Labels
enhancement improvement or small functionality added to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using refactored handlers
2 participants
@joe94 @kcajmagic