Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added metric to see how often caduceus is modifying the wrp #216

Merged
merged 5 commits into from
May 21, 2020

Conversation

kristinapathak
Copy link
Contributor

part of investigating what we want to do for #174

@kristinapathak kristinapathak added this to the Unreleased milestone May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #216 into master will increase coverage by 1.16%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   68.92%   70.09%   +1.16%     
==========================================
  Files           7        7              
  Lines         737      759      +22     
==========================================
+ Hits          508      532      +24     
+ Misses        216      214       -2     
  Partials       13       13              
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
http.go 94.44% <70.00%> (-5.56%) ⬇️
metrics.go 100.00% <100.00%> (ø)
caduceus_type.go 100.00% <0.00%> (ø)
outboundSender.go 84.46% <0.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5d084...8013bd7. Read the comment docs.

@schmidtw schmidtw merged commit 9b3e083 into master May 21, 2020
@schmidtw schmidtw deleted the encode-metric branch May 21, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants