Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty queue #237

Merged
merged 7 commits into from
Oct 8, 2020
Merged

Empty queue #237

merged 7 commits into from
Oct 8, 2020

Conversation

j-mai
Copy link
Contributor

@j-mai j-mai commented Oct 7, 2020

When a webhook expires, empty the queue all at once instead of emptying one by one

Closes #231

@j-mai j-mai requested a review from kcajmagic October 7, 2020 17:40
@guardrails
Copy link

guardrails bot commented Oct 7, 2020

⚠️ We detected security issues in this pull request:

Vulnerable Libraries (1)

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@@ -918,3 +919,70 @@ func TestOverflow(t *testing.T) {

assert.NotNil(output.String())
}

func TestDispatcherEmptyQueue(t *testing.T) {
fmt.Printf("\n\nTestingDispatcherEmptyQueue:\n\n")

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #237 into main will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   69.39%   69.67%   +0.27%     
==========================================
  Files           8        8              
  Lines         732      732              
==========================================
+ Hits          508      510       +2     
+ Misses        205      203       -2     
  Partials       19       19              
Impacted Files Coverage Δ
outboundSender.go 82.45% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb32008...6b3ffa4. Read the comment docs.

@j-mai j-mai requested a review from kcajmagic October 7, 2020 18:30
@j-mai j-mai merged commit 7bd4d19 into xmidt-org:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty queue when a webhook expires
2 participants