Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Argus integration #239

Merged
merged 3 commits into from
Nov 4, 2020
Merged

Update Argus integration #239

merged 3 commits into from
Nov 4, 2020

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Oct 30, 2020

No description provided.

@joe94 joe94 marked this pull request as draft October 30, 2020 23:26
@joe94 joe94 self-assigned this Oct 30, 2020
@guardrails
Copy link

guardrails bot commented Oct 30, 2020

⚠️ We detected security issues in this pull request:

Vulnerable Libraries (2)

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #239 into main will increase coverage by 2.33%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   70.08%   72.41%   +2.33%     
==========================================
  Files           8        7       -1     
  Lines         732      667      -65     
==========================================
- Hits          513      483      -30     
+ Misses        201      172      -29     
+ Partials       18       12       -6     
Impacted Files Coverage Δ
caduceus_type.go 100.00% <ø> (ø)
main.go 0.00% <0.00%> (ø)
metrics.go 100.00% <ø> (+1.81%) ⬆️
outboundSender.go 83.50% <ø> (ø)
primaryHandler.go 64.28% <100.00%> (+0.87%) ⬆️
senderWrapper.go 86.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ffa47...968ed5d. Read the comment docs.

@joe94 joe94 marked this pull request as ready for review November 4, 2020 22:39
@joe94 joe94 merged commit a3fe2a6 into main Nov 4, 2020
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

46.2% 46.2% Coverage
0.0% 0.0% Duplication

@joe94 joe94 deleted the feature/argusIntegration branch November 4, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant