Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ancla integration #259

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Ancla integration #259

merged 6 commits into from
Mar 15, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Mar 13, 2021

No description provided.

@joe94 joe94 linked an issue Mar 13, 2021 that may be closed by this pull request
Update webhook integration #238
Closed
@codecov
Copy link

codecov bot commented Mar 13, 2021 •
edited
Loading

Codecov Report

Merging #259 (241eda6) into main (91979cf) will increase coverage by 1.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   71.36%   72.47%   +1.10%     
==========================================
  Files           7        7              
  Lines         646      672      +26     
==========================================
+ Hits          461      487      +26     
  Misses        173      173              
  Partials       12       12
Impacted Files Coverage Δ
caduceus_type.go 100.00% <ø> (ø)
main.go 0.00% <0.00%> (ø)
outboundSender.go 83.62% <ø> (ø)
primaryHandler.go 65.90% <100.00%> (+1.62%) ⬆️
senderWrapper.go 86.11% <100.00%> (ø)
metrics.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91979cf...8a4e74a. Read the comment docs.

kristinapathak
kristinapathak approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

go.mod Outdated
github.com/xmidt-org/webpa-common v1.11.5-0.20210120235745-b98c7113262c
github.com/stretchr/testify v1.7.0
github.com/xmidt-org/ancla v0.1.2
github.com/xmidt-org/webpa-common v1.11.5-0.20210312223801-2c5c6944d659
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we release webpa-common?

@joe94 joe94 merged commit 890c248 into main Mar 15, 2021
@joe94 joe94 deleted the feature/ancla branch March 15, 2021 19:22
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update webhook integration
2 participants
@joe94 @kristinapathak