Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped webpa-common and ancla, fixed ancla panic #298

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Conversation

kristinapathak
Copy link
Contributor

  • panic in ancla post webhooks endpoint was fixed in newest ancla version
  • also fixed partner ID checking for post webhooks endpoint to use configuration
  • turned off partner ID checking for local docker yaml

- panic in ancla post webhooks endpoint was fixed in newest ancla version
- also fixed partner ID checking for post webhooks endpoint to use configuration
- turned off partner ID checking for local docker yaml
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #298 (4227459) into main (36c7b02) will decrease coverage by 1.83%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   67.03%   65.20%   -1.84%     
==========================================
  Files           8        8              
  Lines         813      773      -40     
==========================================
- Hits          545      504      -41     
- Misses        250      252       +2     
+ Partials       18       17       -1     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
primaryHandler.go 61.90% <100.00%> (-1.74%) ⬇️
metrics.go 100.00% <0.00%> (ø)
outboundSender.go 82.44% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c7b02...4227459. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 8a878d7 into main Nov 29, 2021
@kristinapathak kristinapathak deleted the bump-ancla branch November 29, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants