Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added zap logger and basculehelper package #403

Merged
merged 7 commits into from
Jun 15, 2023
Merged

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Jun 12, 2023

@maurafortino maurafortino added the webpa-common archival/deprecation work related to the archival & deprecation of webpa-common label Jun 12, 2023
@maurafortino maurafortino self-assigned this Jun 12, 2023
@guardrails
Copy link

guardrails bot commented Jun 12, 2023

⚠️ We detected 4 security issues in this pull request:

Vulnerable Libraries (4)
Severity Details
N/A pkg:golang/github.com/xmidt-org/sallust@v0.2.2@v0.2.2 - no patch available
N/A pkg:golang/github.com/xmidt-org/webpa-common/v2@v2.1.4@v2.1.4 - no patch available
N/A pkg:golang/github.com/xmidt-org/ancla@v0.3.11@v0.3.11 - no patch available
N/A pkg:golang/github.com/xmidt-org/bascule@v0.11.5@v0.11.5 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino marked this pull request as draft June 12, 2023 13:18
@maurafortino maurafortino marked this pull request as ready for review June 14, 2023 20:35
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #403 (44382da) into main (12450b0) will decrease coverage by 1.62%.
The diff coverage is 34.04%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   68.20%   66.58%   -1.62%     
==========================================
  Files           9       10       +1     
  Lines        1321     1293      -28     
==========================================
- Hits          901      861      -40     
- Misses        391      403      +12     
  Partials       29       29              
Flag Coverage Δ
unittests 66.58% <34.04%> (-1.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
anclaHelper.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
senderWrapper.go 77.95% <ø> (ø)
basculeLogging.go 35.71% <8.33%> (-11.91%) ⬇️
outboundSender.go 83.55% <47.36%> (+1.40%) ⬆️
primaryHandler.go 64.11% <68.75%> (ø)
http.go 89.42% <90.90%> (-0.85%) ⬇️
caduceus_type.go 100.00% <100.00%> (ø)

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

35.8% 35.8% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🍻

@maurafortino maurafortino merged commit 6478bfb into main Jun 15, 2023
@maurafortino maurafortino deleted the logger-basculehelper branch June 15, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webpa-common archival/deprecation work related to the archival & deprecation of webpa-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants