Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: replace genericDoReason error reason with unknown #490

Merged
merged 1 commit into from
Oct 22, 2024
Merged

patch: replace genericDoReason error reason with unknown #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions eventDispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,5 @@ func getDroppedMessageReason(err error) string {
}

// check for http `Do` related errors
if reason := getDoErrReason(err); reason != genericDoReason {
return reason
}

return unknown
return getDoErrReason(err)
}
1 change: 0 additions & 1 deletion metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ const (
unroutableDestinationReason = "unroutable_destination"
encodeErrReason = "encoding_err"
fullQueueReason = "full outbound queue"
genericDoReason = "do_error"
deadlineExceededReason = "context_deadline_exceeded"
contextCanceledReason = "context_canceled"
addressErrReason = "address_error"
Expand Down
2 changes: 1 addition & 1 deletion workerPool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,5 +144,5 @@ func getDoErrReason(err error) string {
}
}

return genericDoReason
return unknown
}