Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the argument order so the url isn't lost in the middle of things. #124

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Sep 2, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #124 (a6af4cb) into main (da8416e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   97.74%   97.74%           
=======================================
  Files           5        5           
  Lines         577      577           
=======================================
  Hits          564      564           
  Misses          9        9           
  Partials        4        4           
Flag Coverage Δ
unittests 97.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
listener.go 95.72% <100.00%> (ø)

@schmidtw schmidtw merged commit 2a130e9 into main Sep 3, 2023
15 checks passed
@schmidtw schmidtw deleted the improve-arg-order branch September 3, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant