ArchUnit verification fails for annotated aggregate references as collection elements

[etrandafir93]

When it comes to validating the annotated classes, JMoleculesDddRules fails to catch the violation for an aggregate referencing a Collection of other aggregates as shown below:

@AggregateRoot 
class AnnotatedAggregate { ... }

@AggregateRoot
class OtherAnnotatedAggregate {
    AnnotatedAggregate invalidAnnotatedAggregate; // <-- throws violation (correct)
    Collection<AnnotatedAggregate> invalidAnnotatedAggregateInCollection; // <-- doesn't throw violation (not correct)
}

Reproduced in tests, here.

PS: this works ok for the interfaces, and only fails with the annotations. Also, I believe it can be interesting to have that same test/assertions run against two set of objects (one using the interfaces and its equivalent that uses annotations).

If the project is open for contributions, I wouldn't mind looking into it.

---

Later edit: This rule also seems to be skipped when it comes to annotated objects: Aggregates only refer to entities that are declared to be part of it.

Example here:

@AggregateRoot
static class SomeAnnotatedAggregate {
    // ...
    AnnotatedEntity valid;
}

@AggregateRoot
static class OtherAnnotatedAggregate {
    AnnotatedEntity invalidAnnotatedEntity; // <-- doesn't throw violation (not correct)
    Collection<AnnotatedEntity> invalidAnnoatedEntityInCollection; // <-- doesn't throw violation (not correct)
}

I have added these failing test cases to my branch and created PR (#254) for visibility:
#254

[odrotbohm]

I've applied the addition for the collection element verification. For the entity verification, please refer to my comment on the PR.