Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Identity annotation is missing in kmolecules-ddd #97

Closed
Michal-Kucera opened this issue Jul 20, 2023 · 3 comments
Closed

@Identity annotation is missing in kmolecules-ddd #97

Michal-Kucera opened this issue Jul 20, 2023 · 3 comments
Assignees
@odrotbohm
Labels
module: ddd Domain-Driven Design related support type: enhancement New feature or request
Milestone
1.8

Comments

@Michal-Kucera
Copy link

Hi there,

It appears that the @Identity annotation is not available in kmolecules-ddd (I'm using version 1.7.0). Is this on purpose?

Thanks!
Michal
@odrotbohm odrotbohm self-assigned this Jul 21, 2023
@odrotbohm odrotbohm added this to the 1.8 milestone Jul 21, 2023
@odrotbohm odrotbohm added type: enhancement New feature or request module: ddd Domain-Driven Design related support labels Jul 21, 2023
@odrotbohm
Copy link
Member

That's an oversight. IIRC we added @Identity after the Kotlin module was added and simply forgot to also add its counterpart.

@odrotbohm odrotbohm changed the title @Identity annotation is missing in kmolecules-ddd @Identity annotation is missing in kmolecules-ddd Jul 21, 2023
odrotbohm added a commit that referenced this issue Jul 21, 2023
@odrotbohm
GH-97 - Add Kotlin @Identity counterpart to kmolecules-ddd.
cfbd425
odrotbohm added a commit that referenced this issue Jul 21, 2023
@odrotbohm
GH-97 - Add missing Apache license copyright headers.
e224d40
@Michal-Kucera
Copy link
Author

Thanks for the explanation @odrotbohm , I wanted to raise a quick PR, but you are faster, thanks!

@odrotbohm
Copy link
Member

It's great timing nonetheless as I was just about to ship 1.8 🙃.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
module: ddd Domain-Driven Design related support type: enhancement New feature or request
Projects
None yet
Milestone
1.8
Development

No branches or pull requests
2 participants
@odrotbohm @Michal-Kucera