Fix reconnection issues #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ejabberd is restarted with `ejabberdctl restart` the node-xmpp client does not enter a reconnect state. Instead the connection is ended. This code attempts to handle reconnection in a somewhat janky way. A more intelligent backoff is probably required.
Testing timers is much easier with sinon.
|
Does anyone have confirmation that this fixes #58? |
|
From my limited local testing with ejabberd it solved problems where hubot would not come online after |
Remove any listeners from the previous connection as they can cause issues with messages being logged more than once.
|
I'm still seeing duplicated responses and log entries, even with the new changes: hubot-dev [9:05 AM] bnied [9:05 AM] [this command causes a reset with Slack] bnied [9:07 AM] hubot-dev [9:07 AM] hubot-dev [9:07 AM] hubot-dev [9:07 AM] hubot-dev [9:07 AM] hubot-dev [9:07 AM] hubot-dev [9:07 AM] |
|
I'm not sure of what the problem is then. How is the connection being reset? |
|
I'm running a command which is causing Slack to send an offline event. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this resolves #58 and #63. When ejabberd - and I assume other xmpp servers - are hard reset node-xmpp gets a
ECONNREFUSEDerror which prevents thereconnectoption from working. In these situations, theendevent is emitted. The adapter now handles this event and attempts to reconnect.If this reconnection process fails the bot process will be terminated. This will allow process managers like supervisord to restart the bot.