Node Streams Debugging + Logging #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
force-pushed
the
insipx/stream-debugging
branch
from
9aa063b
to
7f64078
Compare
insipx
force-pushed
the
insipx/stream-debugging
branch
from
7f64078
to
47f14af
Compare
insipx
force-pushed
the
insipx/stream-debugging
branch
from
f32d93b
to
d7e456e
Compare
nplasterer
approved these changes
Nov 26, 2024
insipx
force-pushed
the
insipx/stream-debugging
branch
from
332824b
to
c5381bf
Compare
insipx
force-pushed
the
insipx/stream-debugging
branch
from
c5381bf
to
6f45466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds more logs with an
inbox_idkey to filter by specific clients viainbox_id.Node was completely missing stream messages, probably because of
ThreadSafeFunctionUltimately,
napi4feature needed to be enabled. This should fix @humanagent issues with the streams, and a streaming test was added to node which should ensure this does not happen in the future