Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercase address when checking association state #1362

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Lowercase address when checking association state #1362

merged 3 commits into from
Dec 2, 2024
+94 −93

Conversation

rygine
Copy link
Collaborator

@rygine rygine commented Dec 2, 2024

Summary

  • Removed is_installation_authorized and is_address_authorized from Client
  • Moved is_installation_authorized and is_address_authorized to inbox_id mod
  • Lowercased address passed to is_address_authorized before checking association state
  • Added tests for is_installation_authorized and is_address_authorized
  • Updated version and CHANGELOG for release

@rygine rygine requested review from a team as code owners December 2, 2024 22:04
nplasterer
nplasterer approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@nplasterer nplasterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@rygine rygine merged commit 0a078b0 into main Dec 2, 2024
6 checks passed
@rygine rygine deleted the rygine/nb-update branch December 2, 2024 22:10
@nplasterer nplasterer restored the rygine/nb-update branch December 3, 2024 23:12
@nplasterer nplasterer deleted the rygine/nb-update branch December 3, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rygine @nplasterer