Refactor of stream_all_messages, fix flaky stream tests #1870
ffi
5 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 5 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.79.0 (129f3b996 2024-06-10)
- cargo 1.79.0 (ffa9cf99a 2024-06-03)
- clippy 0.1.79 (129f3b9 2024-06-10)
Annotations
Check warning on line 962 in src/mls.rs
github-actions / ffi
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/mls.rs:962:13
|
962 | handle: Arc<Mutex<Option<JoinHandle<Result<(), ClientError>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 962 in src/mls.rs
github-actions / ffi
very complex type used. Consider factoring parts into `type` definitions
warning: very complex type used. Consider factoring parts into `type` definitions
--> src/mls.rs:962:13
|
962 | handle: Arc<Mutex<Option<JoinHandle<Result<(), ClientError>>>>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
Check warning on line 2 in src/mls.rs
github-actions / ffi
unused import: `crate::logger::init_logger`
warning: unused import: `crate::logger::init_logger`
--> src/mls.rs:2:5
|
2 | use crate::logger::init_logger;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 2 in src/mls.rs
github-actions / ffi
unused import: `crate::logger::init_logger`
warning: unused import: `crate::logger::init_logger`
--> src/mls.rs:2:5
|
2 | use crate::logger::init_logger;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
Check warning on line 10 in /home/runner/work/libxmtp/libxmtp/xmtp_mls/src/subscriptions.rs
github-actions / ffi
unused import: `UnboundedSender`
warning: unused import: `UnboundedSender`
--> /home/runner/work/libxmtp/libxmtp/xmtp_mls/src/subscriptions.rs:10:24
|
10 | sync::mpsc::{self, UnboundedSender},
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default