Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've been digging into issues with building the
libxmtp
docker image.They all fail with errors that look like this.
Using the default profile in the base rust image resolves the issue. It's a bit strange, given that the only difference between the default profile and the one we are using (including the components manually added) appears to be
rust-docs
.I'd like to better understand what the root cause is, but I think we should merge this to unblock
libxmtp
CI until we have a better solution. I can see the case for including the minimal profile in the base image if this is to be used for production builds as well as CI.Notes
I tested this by building the image locally and using my local image in
libxmtp
. Everything worked after I did that. But if this is a more exotic issue than I think, maybe this won't actually fix it when built in CI.