Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default rust profile #5

Closed
wants to merge 1 commit into from
Closed

Use default rust profile #5

wants to merge 1 commit into from

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Nov 17, 2023

Summary

I've been digging into issues with building the libxmtp docker image.

They all fail with errors that look like this.
CleanShot 2023-11-17 at 14 20 41@2x

Using the default profile in the base rust image resolves the issue. It's a bit strange, given that the only difference between the default profile and the one we are using (including the components manually added) appears to be rust-docs.

I'd like to better understand what the root cause is, but I think we should merge this to unblock libxmtp CI until we have a better solution. I can see the case for including the minimal profile in the base image if this is to be used for production builds as well as CI.

Notes

I tested this by building the image locally and using my local image in libxmtp. Everything worked after I did that. But if this is a more exotic issue than I think, maybe this won't actually fix it when built in CI.

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for troubleshooting that. I can see the case for default profile as well. In production we would likely use the build result from this container rather than the container itself so this will not have a size impact on production.

@jac18281828
Copy link
Contributor

merged

@jac18281828 jac18281828 deleted the nm/use-default-profile branch November 18, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants