Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6: rust 1.74.1 update #7

Merged
merged 1 commit into from
Dec 7, 2023
Merged

6: rust 1.74.1 update #7

merged 1 commit into from
Dec 7, 2023

Conversation

jac18281828
Copy link
Contributor

closes #6

@jac18281828 jac18281828 added the release Software releases label Dec 7, 2023
@jac18281828 jac18281828 self-assigned this Dec 7, 2023
@jac18281828
Copy link
Contributor Author

Copy link
Contributor

@neekolas neekolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I see here is the CHANGELOG.md and not the actual version bump

@jac18281828 jac18281828 merged commit 4707339 into main Dec 7, 2023
1 check passed
@jac18281828 jac18281828 deleted the jac/1741 branch December 7, 2023 21:42
@jac18281828
Copy link
Contributor Author

All I see here is the CHANGELOG.md and not the actual version bump

When the container is updated it will pull the version during the build.

@neekolas
Copy link
Contributor

neekolas commented Dec 8, 2023

We should think about pinning versions so it doesn't get incidentally updated again later. I've run into nasty bugs with surprise Docker version updates by depending on the latest tag.

@jac18281828
Copy link
Contributor Author

We should think about pinning versions so it doesn't get incidentally updated again later. I've run into nasty bugs with surprise Docker version updates by depending on the latest tag.

We do pin to 'stable' but that does not require us to set the number. I like the convenience of not having to change version numbers and simply rebuild the container. I understand what you mean about potential versioning problems. If we are not comfortable with 'latest' I have also tagged the release versions. You can explore that here:

https://github.com/xmtp/rust/pkgs/container/rust

As this is a dev container I recommend using the latest version. Everything is pinned to stable so this should give us the stable code with the latest security fixes.

@jac18281828
Copy link
Contributor Author

For documentation purposes, the only way to trigger the build is to push a tag on this repo. That should be a deliberate act and not something that would result in surprises. That in particular is one of the reasons I've shared a pull request to update the version. Everyone has a chance to build on latest, test and comment before we release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Software releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: 1.74.1
3 participants