-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6: rust 1.74.1 update #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All I see here is the CHANGELOG.md and not the actual version bump
When the container is updated it will pull the version during the build. |
We should think about pinning versions so it doesn't get incidentally updated again later. I've run into nasty bugs with surprise Docker version updates by depending on the |
We do pin to 'stable' but that does not require us to set the number. I like the convenience of not having to change version numbers and simply rebuild the container. I understand what you mean about potential versioning problems. If we are not comfortable with 'latest' I have also tagged the release versions. You can explore that here: https://github.com/xmtp/rust/pkgs/container/rust As this is a dev container I recommend using the latest version. Everything is pinned to stable so this should give us the stable code with the latest security fixes. |
For documentation purposes, the only way to trigger the build is to push a tag on this repo. That should be a deliberate act and not something that would result in surprises. That in particular is one of the reasons I've shared a pull request to update the version. Everyone has a chance to build on latest, test and comment before we release. |
closes #6