Enable RBAC in Travis-CI Minikube cluster and fix APIServer ConfigMap/Secret Role APIGroup #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmudrii
added
the
ready-for-review
sttts
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
etcdproxy-manage-certsRole which ensures the EtcdProxyController ServiceAccount can get and write to ConfigMaps and Secrets in the APIServer namespace, has specified APIGroupv1, which is incorrect, as roles for resources in the Core API should not specify any APIGroup.That caused controller to misbehave when deployed in-cluster once we merged #35.
The E2E tests in Travis-CI have not caught this issue, as RBAC is disabled by default in Minikube. This PR also enables RBAC. In order to enable RBAC, we have to make
defaultServiceAccount acluster-adminor otherwise the kube-dns fails.Relevant issue kubernetes/minikube#1722