v3.4 - see CHANGELOG.md

xnl-h4ck3r · Jul 15, 2023 · 48760f2 · 48760f2
1 parent e785fcd
commit 48760f2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 ## Changelog
 
+- v3.4
+
+  - Changed
+
+    - Fix a bug that was causing the `Show params as query string` option to not display anything if the `Include common parameters` option is not ticked.
+    - Ensure there is a newline character at the end of the final line on output files.
+
 - v3.3
 
   - New

diff --git a/GAP.py b/GAP.py
@@ -8,7 +8,7 @@
 
 Good luck and good hunting! If you really love the tool (or any others), or they helped you find an awesome bounty, consider BUYING ME A COFFEE! (https://ko-fi.com/xnlh4ck3r) (I could use the caffeine!)
 """
-VERSION="3.3"
+VERSION="3.4"
 
 from burp import IBurpExtender, IContextMenuFactory, IScopeChangeListener, ITab
 from javax.swing import (
@@ -1353,7 +1353,7 @@ def cbShowQueryString_clicked(self, e=None):
         # Show the parameter list or query string depending on the option selected
         if self.cbShowQueryString.isSelected():
             # Set the values if not already set
-            if self.outParamQuery.text == "":
+            if self.outParamQuery.text == "" or self.outParamQuery.text == "NO PARAMETERS FOUND":
                 index = 0
                 paramQuery = ""
                 self.outParamQuery.text = "UPDATING..."
@@ -3048,6 +3048,7 @@ def fileWriteParams(self):
                                     f.write(self.txtParamsWithURL.encode("UTF-8").replace("  "," "))
                                 else:
                                     f.write(self.txtParamsOnly.encode("UTF-8"))
+                                f.write("\n".encode("UTF-8"))
                                 f.close()
                             except Exception as e:
                                 self._stderr.println("fileWriteParams 2")
@@ -3063,6 +3064,7 @@ def fileWriteParams(self):
                                         f.write(self.txtParamsWithURL.encode("UTF-8").replace("  "," "))
                                     else:
                                        f.write(self.txtParamsOnly.encode("UTF-8"))
+                                    f.write("\n".encode("UTF-8"))
                                     f.close()
                                 except Exception as e:
                                     self._stderr.println("fileWriteParams 3")
@@ -3090,6 +3092,7 @@ def fileWriteParams(self):
                                 fileText = "\n".join(sorted(set(fileText.split())))
                                 with open(os.path.expanduser(self.getFilePath(root) + "_params.txt"), "w") as f:
                                     f.write(fileText)
+                                    f.write("\n".encode("UTF-8"))
                                     f.close
 
         except IOError as e:
@@ -3132,6 +3135,7 @@ def fileWriteLinks(self):
                                         f.write(self.txtLinksOnlyInScopeOnly.encode("UTF-8"))
                                     else:
                                         f.write(self.txtLinksOnly.encode("UTF-8"))
+                                f.write("\n".encode("UTF-8"))
                                 f.close()
                             except Exception as e:
                                 self._stderr.println("fileWriteLinks 2")
@@ -3153,6 +3157,7 @@ def fileWriteLinks(self):
                                             f.write(self.txtLinksOnlyInScopeOnly.encode("UTF-8"))
                                         else:
                                             f.write(self.txtLinksOnly.encode("UTF-8"))
+                                    f.write("\n".encode("UTF-8"))
                                     f.close()
                                 except Exception as e:
                                     self._stderr.println("fileWriteLinks 3")
@@ -3189,6 +3194,7 @@ def fileWriteLinks(self):
                                 fileText = "\n".join(sorted(set(fileText.split())))
                                 with open(os.path.expanduser(self.getFilePath(root) + "_links.txt"), "w") as f:
                                     f.write(fileText)
+                                    f.write("\n".encode("UTF-8"))
                                     f.close
 
         except IOError as e:
@@ -3229,6 +3235,7 @@ def fileWriteWords(self):
                                         f.write(self.txtWordsWithURL.encode("UTF-8").replace("  "," "))
                                     else:
                                         f.write(self.txtWordsOnly.encode("UTF-8"))
+                                    f.write("\n".encode("UTF-8"))
                                     f.close()
                                 except Exception as e:
                                     self._stderr.println("fileWriteWords 2")
@@ -3244,6 +3251,7 @@ def fileWriteWords(self):
                                             f.write(self.txtWordsWithURL.encode("UTF-8").replace("  "," "))
                                         else:
                                             f.write(self.txtWordsOnly.encode("UTF-8"))
+                                        f.write("\n".encode("UTF-8"))
                                         f.close()
                                     except Exception as e:
                                         self._stderr.println("fileWriteWords 3")
@@ -3271,6 +3279,7 @@ def fileWriteWords(self):
                                     fileText = "\n".join(sorted(set(fileText.split())))
                                     with open(os.path.expanduser(self.getFilePath(root) + "_words.txt"), "w") as f:
                                         f.write(fileText)
+                                        f.write("\n".encode("UTF-8"))
                                         f.close
 
             except IOError as e:

diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 <center><img src="https://raw.githubusercontent.com/xnl-h4ck3r/GAP-Burp-Extension/main/GAP/images/title.png"></center>
 
-## About - v3.3
+## About - v3.4
 
 This is an evolution of the original getAllParams extension for Burp. Not only does it find more potential parameters for you to investigate, but it also finds potential links to try these parameters on, and produces a target specific wordlist to use for fuzzing.
 The full Help documentation can be found [here] (https://github.com/xnl-h4ck3r/burp-extensions/blob/main/GAP%20Help.md) or from the Help icon on the GAP tab.