Parse KEY statements within CREATE TABLE statements #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like (after re-reading the contributing guidelines) that I also will need to update README.md and CHANGELOG.txt. I'll do this if I receive feedback that I'm on the right track here. |
|
Hi, only update the CHANGELOG, the bash script ( |
|
Thanks! Apologies for missing the flake8 check initially. Should be updated now. |
|
@cfhowes merge conflict with main branch - need to resolve it. Please, get changes from main branch and re-run tests on your local machine to re-generate parsertab.py with your changes |
|
@cfhowes released in version 0.31.3 https://pypi.org/project/simple-ddl-parser/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have DDL with KEY statements as part of the CREATE TABLE statement. This is a seemingly valid way to indicate an index in SQL. I created a test case with a sample of the SQL I am working with, and the desired listing of an index.
I do not know the parser grammar all that well - it's possible that while the code works and passes the test cases that my implementation is not technically correct. Please give me pointers and I'll fix it up.