Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default name for xodball saved from browser IDE #1474

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

evgenykochetkov
Copy link
Contributor

@evgenykochetkov evgenykochetkov commented Oct 16, 2018

A very small tweak.

The previous behavior caused some pain when creating quick projects in browser IDE, because it would save it as just .xodball, which was not correctly associated with XOD IDE.

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to suggest name inheritance in the opposite direction. That is, when a xoder saves a project for the first time project.name is derived from the filename.

If we do it latter, my-project.xodball would be a better default then untitled.xodball since it is presented to a xoder in the project browser. Do you have any arguments in favor of untitled rather than my-project?

Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but I agree with @nkrkv comment. ;)

@evgenykochetkov evgenykochetkov force-pushed the tweak-default-name-to-saved-xodball branch from aaeb70a to f2cd526 Compare October 16, 2018 14:28
@evgenykochetkov
Copy link
Contributor Author

evgenykochetkov commented Oct 16, 2018

Changed the default to my-project 👍🏻

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants