Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill running arduino-cli processes on closing the IDE #1523

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Kill running arduino-cli processes on closing the IDE #1523

merged 2 commits into from
Nov 1, 2018

Conversation

brusherru
Copy link
Contributor

It fixes #1501

@brusherru brusherru self-assigned this Nov 1, 2018
@brusherru brusherru requested a review from a team November 1, 2018 10:07
@brusherru brusherru changed the base branch from master to 0.25.x November 1, 2018 10:07
nkrkv
nkrkv approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Works fine on Linux. Have you tested it on Windows?

@brusherru
Copy link
Contributor Author

@nkrkv yes, I did and it works :)

@brusherru brusherru merged commit 2923e30 into 0.25.x Nov 1, 2018
@brusherru brusherru deleted the fix-1501-stale-arduino-cli-process branch November 1, 2018 12:24
@nkrkv nkrkv added the hotfix Issue/PR for a patch release label Nov 6, 2018
@nkrkv nkrkv mentioned this pull request Nov 6, 2018
Merged
This was referenced Aug 1, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

Assignees

@brusherru brusherru

Labels
hotfix Issue/PR for a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brusherru @nkrkv