Tweak values by editing values of tweak nodes in Inspector #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Feb 6, 2019
There was a problem hiding this comment.
Coooool!
Found a bug.
- Place a
text-lcd-16x2-i2c - Bind “Hello” on
L1 - Place a
tweak-string-16and link it toL2 - Set tweak value to “bro”
- Upload with debugger enabled
Expected behavior
- The display shows “Hello bro”
Actual behavior
- The display shows “Hello” (the second line is empty) until I change the tweak value to some other value. Starting from the change everything works fine
packages/xod-client/src/editor/containers/Patch/modes/debugging.jsx
Outdated
Show resolved
Hide resolved
brusherru
requested changes
Feb 6, 2019
There was a problem hiding this comment.
One issue with tweak-string-16.
I connected it with watch node and it always shows a message like "↘ +XOD:99:6:" on start debugging, even if I bound something into it. And pressing enter with the same value does nothing. Watch node contains watch label.
But when I change tweak-string-16 value to something new — it works as expected.
Probably it's a bug in C++ implementation...
P.S.
I thought that I can Simulate it too 😢
|
|
||
| export default ({ getState }) => next => action => { | ||
| const state = getState(); | ||
| const result = next(action); |
There was a problem hiding this comment.
I think it does not make sense in this case, but next(action) can change the state, so I prefer to get state after calling next(action) :)
…es to serial from Inspector during debug session
evgenykochetkov
force-pushed
the
feat-tweaks-ui
branch
2 times, most recently
from
e1c9b37
to
d462261
Compare
check again, please |
evgenykochetkov
force-pushed
the
feat-tweaks-ui
branch
from
691c7d0
to
c2e644c
Compare
evgenykochetkov
force-pushed
the
feat-tweaks-ui
branch
from
c2e644c
to
79fbb97
Compare
This was referenced Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works for all available tweak nodes except
tweak-pulseCloses #1624
Closes #1626
Closes #32