-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix normalizing pin labels for C++ and add QuickHelp for C++ and Tabtest editors #1682
Conversation
63d3658
to
dd93f82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A general note. I recommend to avoid mixing two concepts: pin name normalization (converting empty labels to IN1
, IN2
, OUT
, etc) and C++ escaping (getting rid of invalid C++ chars). They should be named accordingly and used in a pipe where necessary.
packages/xod-project/src/internal/unicodeCharsToUnicodeSequence.js
Outdated
Show resolved
Hide resolved
dd93f82
to
80b617a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. One more time. The escape functions are quite generic to be unbound from the pin/project concept.
-
cppEscape
andunicodeCharsToUnicodeSequence
should be inxod-func-tools
, not inxod-project
- Changes in
*.re*
should reflect this as well
80b617a
to
e1a55c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛
Steps to reproduce
- Open
xod/math/clip
- Change the label of
X
toX°-§
- Open its
not-implemented-in-xod
- Open Quick Help
Expected behavior
- The quickhelp lists the input escaped:
input_XUxxxx_Uxxxx
Actual behavior
- The input is listed as
X°_§
(only the hyphen is transformed)
e1a55c1
to
c191278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍 Now excellent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c191278
to
6b320da
Compare
It fixes #1664
Also, it adds a new feature: QuickHelp now contains a list of inputs/outputs available in the C++ editor and in the tabtest editor. Also, it contains a link to a full reference in our docs.