-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tabline scrollable #1694
Make tabline scrollable #1694
Conversation
e0a11db
to
a7fb15e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm! The code is fine.
A few things I spotted that annoy a bit:
- If I open a new tab when the tabline is overflown already, I don’t see the newly activated tab. In particular, this would cause confusion when the debugger tab opens.
- If I click a tab which is half-hidden/half-visible, it “blinks.” It shows completely when the button is held down and disappears when the button is released. Looks like it is caused by drag-n-drop
- The < > arrows are misaligned vertically with tab contents
(1) and (2) can be solved by automatically scrolling to a tab being clicked or activated. By scrolling to I mean ensuring it is completely fit in the visible tabline area.
(3) Looks like a problem of tabs, not the buttons. Should we push tab contents up a couple of pixels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 Bugs detected:
- I can't scroll any sidebar pane if I opened only one. (Show only ProjectBrowser and try to scroll it)
- The previous bug moves Deployment pane out of view area
- Even If I open Inspector and Help panes in the one sidebar, it moves Deployment pane and I can't see an entire Help pane content.
🐛 |
Possibly, bug 🤷♂️
|
About design 🤓
|
5a9632f
to
4246659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…tle when expanding
e69d888
to
0097631
Compare
Closes #1087
Closes #414