Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak-pulse nodes #1701

Merged
merged 2 commits into from
Feb 27, 2019
Merged

tweak-pulse nodes #1701

merged 2 commits into from
Feb 27, 2019

Conversation

evgenykochetkov
Copy link
Contributor

@evgenykochetkov evgenykochetkov commented Feb 26, 2019 •
edited
Loading

  • add tweak-pulse to xod/debug
  • add UI for sending pulses during debug sessions through tweak-pulse nodes

Closes #1627

@evgenykochetkov evgenykochetkov self-assigned this Feb 26, 2019
@nkrkv
Copy link
Member

nkrkv commented Feb 27, 2019

Should it close #1627? If so, please refer in the PR description

nkrkv
nkrkv requested changes Feb 27, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

A few minor notes below.

packages/xod-client/src/editor/components/inspectorWidgets/PulseTweakWidget.jsx Outdated Show resolved Hide resolved
packages/xod-client/src/editor/components/inspectorWidgets/PulseTweakWidget.jsx Outdated Show resolved Hide resolved
workspace/__lib__/xod/debug/tweak-pulse/patch.xodp Outdated Show resolved Hide resolved
@evgenykochetkov evgenykochetkov force-pushed the feat-add-ui-for-tweak-pulses branch 2 times, most recently from 2aa2716 to 3e97402 Compare February 27, 2019 09:33
nkrkv
nkrkv approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

brusherru
brusherru approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@brusherru brusherru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@evgenykochetkov evgenykochetkov merged commit 1408e20 into master Feb 27, 2019
@evgenykochetkov evgenykochetkov deleted the feat-add-ui-for-tweak-pulses branch February 27, 2019 16:39
@evgenykochetkov evgenykochetkov mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusherru brusherru brusherru approved these changes

@nkrkv nkrkv nkrkv approved these changes

Assignees

@evgenykochetkov evgenykochetkov

Labels
s:client s:stdlib t:feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evgenykochetkov @nkrkv @brusherru