Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hotkeys in Inspector Pin widgets #2040

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fix hotkeys in Inspector Pin widgets #2040

merged 1 commit into from
Sep 17, 2020

Conversation

brusherru
Copy link
Contributor

There is no issue.
Some time ago, when we refactor widgets, we'd lost a method updateValue of Widget class.

Now it's back and these hotkeys will work again:

  • Escape button to cancel changes
  • Arrow keys (optionally with shift key) to change numbers

@brusherru brusherru self-assigned this Sep 17, 2020
@brusherru
fix(xod-client): returned the lost method to make possible cancel cha…
dcda9a4 
…nged value / change numbers with arrows in Inspector Pin inputs
@brusherru brusherru changed the base branch from 0.33.x to 0.35.x September 17, 2020 10:01
evgenykochetkov
evgenykochetkov approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@brusherru brusherru merged commit a98e98c into 0.35.x Sep 17, 2020
@brusherru brusherru deleted the fix-number-input branch September 17, 2020 12:37
@evgenykochetkov evgenykochetkov mentioned this pull request Sep 18, 2020
Merged
This was referenced Sep 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

@nkrkv nkrkv Awaiting requested review from nkrkv

Assignees

@brusherru brusherru

Labels
s:client t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brusherru @evgenykochetkov