Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create nodes with hotkeys while linking #2068

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Conversation

brusherru
Copy link
Contributor

@brusherru brusherru commented Nov 10, 2020

It closes #1770

Each commit refactors a code to reduce code duplication. So probably easier to check out the whole changelog.

Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to create a tweak from a generic pin results in an incorrect patch.
Trying to create a constant node from a generic pin crashes the IDE.

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@brusherru brusherru merged commit e1b24e2 into master Nov 13, 2020
@brusherru brusherru deleted the feat-1770-linking-hotkeys branch November 13, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a xoder I want to create essential nodes with hotkeys while linking so that I can patch faster
3 participants