-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create nodes with hotkeys while linking #2068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
force-pushed
the
feat-1770-linking-hotkeys
branch
from
November 11, 2020 14:34
86f6856
to
e42a770
Compare
evgenykochetkov
requested changes
Nov 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to create a tweak from a generic pin results in an incorrect patch.
Trying to create a constant node from a generic pin crashes the IDE.
brusherru
force-pushed
the
feat-1770-linking-hotkeys
branch
from
November 12, 2020 13:21
e42a770
to
e76dec6
Compare
…constructor node while linking
…h node while linking
…ning electron on CI
brusherru
force-pushed
the
feat-1770-linking-hotkeys
branch
from
November 12, 2020 16:43
d934cf7
to
cd59c21
Compare
nkrkv
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
evgenykochetkov
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1770
Each commit refactors a code to reduce code duplication. So probably easier to check out the whole changelog.