-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recover IDE from runtime exceptions in renderer process #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
requested review from
nkrkv,
knopki,
evgenykochetkov and
gabbapeople
December 8, 2020 13:33
brusherru
force-pushed
the
feat-1476-ide-recover
branch
from
December 10, 2020 23:29
0628db0
to
aa77583
Compare
nkrkv
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
brusherru
force-pushed
the
feat-1476-ide-recover
branch
4 times, most recently
from
December 23, 2020 16:22
5675c31
to
d021a22
Compare
brusherru
force-pushed
the
feat-1476-ide-recover
branch
2 times, most recently
from
January 18, 2021 10:49
d05ff3e
to
02ac662
Compare
evgenykochetkov
approved these changes
Jan 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall user experience is very cool 👍🏻
I have some doubts about a couple of messages, but I might be wrong.
…le state of the IDE to the previous stable state and show an error message
…on any machine by adding a tolerance to the assertion of the node position
brusherru
force-pushed
the
feat-1476-ide-recover
branch
from
January 18, 2021 12:44
02ac662
to
decb8d9
Compare
evgenykochetkov
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1476
It does not catch any exceptions. However, if some error crashes the GUI, the
<Catcher>
component will catch the exception, recover the state of the IDE to the previous stable state and show the report, which might be shared with the developers on GitHub or XOD forum.The report includes:
SECRET
To test this PR you can check it out and then broke something. For example:
render()
method of some componentThis PR also could introduce some bugs in the IDE behavior after being recovered (because of reconstructing
<App>
and its children, so their state will be lost, and they should resubscribe on DOM and IPC events and so on), so I'll be glad if you find something and report it here.Anyway, I'm sure it's better to get a recovered state and possibility to save the project, then just get a crashed IDE. :)