Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizable expanded deployment pane #2081

Merged
merged 2 commits into from
Jan 18, 2021
Merged

Resizable expanded deployment pane #2081

merged 2 commits into from
Jan 18, 2021

Conversation

brusherru
Copy link
Contributor

It closes #2080.

@brusherru brusherru added the wip label Dec 28, 2020
@brusherru brusherru self-assigned this Dec 28, 2020
@brusherru brusherru force-pushed the feat-2080-expand-deployment-pane branch from c710372 to 486d12f Compare January 11, 2021 11:07
@brusherru brusherru removed the wip label Jan 11, 2021
nkrkv
nkrkv approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/xod-client/src/editor/containers/Workarea.jsx Outdated Show resolved Hide resolved
@brusherru brusherru force-pushed the feat-2080-expand-deployment-pane branch 4 times, most recently from 30877fd to 7bd5455 Compare January 14, 2021 16:14
@brusherru brusherru force-pushed the feat-2080-expand-deployment-pane branch from 7bd5455 to 7b1680b Compare January 14, 2021 18:22
@nkrkv
Copy link
Member

nkrkv commented Jan 18, 2021

@evgenykochetkov review?

evgenykochetkov
evgenykochetkov approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with "follow log" is fixed, the issue with positioning of collapsed panel after expanding/collapsing and then resizing window is nearly impossible to reproduce. LGTM.

@brusherru brusherru merged commit 44b07ab into master Jan 18, 2021
@brusherru brusherru deleted the feat-2080-expand-deployment-pane branch January 18, 2021 10:48
@evgenykochetkov evgenykochetkov mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

@nkrkv nkrkv nkrkv approved these changes

Assignees

@brusherru brusherru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a xoder I want to expand deployment pane so that I can see more output at once
3 participants
@brusherru @nkrkv @evgenykochetkov