-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Electron v10, node.js v12 #2084
Conversation
…ade serialport to v9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works/uploads fine on my machine 👍 (I use Arch, BTW)
The only thing I spotted is a couple of warnings at the very beginning of execution:
$ XOD_ARDUINO_CLI=/home/nailxx/xod/arduino-cli yarn start:electron
yarn run v1.22.10
$ lerna run start --scope xod-client-electron --stream
xod-client-electron: $ electron .
xod-client-electron: (node:9209) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
xod-client-electron: (node:9258) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
xod-client-electron: Arduino-cli bin: /home/nailxx/xod/arduino-cli
xod-client-electron: Arduino-cli version: 0.12.1
xod-client-electron: Arduino-cli sketchbook directory: /tmp/xod_temp_sketchbooke3wdOw
Are they ours or from a dependency?
We don't call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also, upgrade
serialport
from 7.x to 9.x