Fix: configure electron-settings for all kinds of processes #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgenykochetkov
approved these changes
Jan 20, 2021
…e the same file paths in all processes
brusherru
force-pushed
the
fix-one-settings-file-for-all-processes
branch
from
79db40f
to
b147b17
Compare
nkrkv
approved these changes
Jan 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no issue 😬
What was wrong?
Updating of the electron also causes an update of the
electron-settingspackage. The newer version of this package changed the default name of the settings file. To keep user settings we've changed the filename, but only in the main process. So it produced a bug when the user compile&upload something with third-party C++ libraries — the libraries from his workspace does not copy if he set a workspace in the custom (not default) path.How it fixed?
On loading/saving settings we always set the path and file name for the settings file (for both kinds of processes).