Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate Hoek.reach calls #99

Closed
WesTyler opened this issue Feb 16, 2017 · 1 comment
Closed

Remove duplicate Hoek.reach calls #99

WesTyler opened this issue Feb 16, 2017 · 1 comment
Assignees
@WesTyler
Labels
enhancement good first issue help wanted
Milestone
v1.2.0

Comments

@WesTyler
Copy link
Member

What are you trying to achieve or the steps to reproduce ?

https://github.com/xogroup/felicity/blob/master/lib/joiGenerator.js#L54

Only Hoek.reach once, then compare to the two values to assign flags.
@WesTyler WesTyler self-assigned this Feb 16, 2017
@WesTyler
Copy link
Member Author

Same thing here: https://github.com/xogroup/felicity/blob/master/lib/helpers.js#L589

@WesTyler WesTyler added this to the v1.2.0 milestone Feb 17, 2017
@lamchakchan lamchakchan mentioned this issue Feb 18, 2017
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesTyler WesTyler

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
1 participant
@WesTyler