Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized call # to Hoek Reach #105

Merged
merged 1 commit into from
Feb 18, 2017
Merged

optimized call # to Hoek Reach #105

merged 1 commit into from
Feb 18, 2017

Conversation

lamchakchan
Copy link
Contributor

Description

  • Removed duplicate calls to Hoek.reach() in both joiGenerator.js and helper.js

Related Issue

#99

Motivation and Context

Optimization

Types of changes

  • Documentation only (no changes to either lib/ or test/ files)
  • Bug fix (non-breaking change which fixes an issue. you didn't modify existing tests)
  • New feature (non-breaking change which adds functionality. you added at least one new test)
  • Breaking change (fix or feature that would cause existing functionality to change. you had to modify existing tests.)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the Hapi.js style guide.
  • I have updated the documentation as needed.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@WesTyler WesTyler merged commit ccd1d4a into xogroup:master Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WesTyler WesTyler WesTyler approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamchakchan @WesTyler