Change the hlgroup of xolox#misc#msg#info #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used the hlgroup 'Title', but this does not accurately represent an informational message. As one can see from `:help hl-Title` and the example commands it lists, 'Title' is meant for section headings in long output, not a single-line message. This inapplicability was especially noticeable in my color scheme (Solarized), which shows 'Title' in an orange-red color. This color does a good job of marking titles in long output, but it makes a single-line message look like an error. Instead, I have made #info use no highlighting – the hlgroup 'None'. I think this hlgroup most accurately represents an “informational message”. It is the same hlgroup that searches are echoed with when pressing `n` and `N`, which also seem like informational messages. While I am editing hlgroups, I also made the capitalization of their names the same as what Vim uses when you run the `:highlight` command. This makes multi-word names a little easier to read, and aids debugging against the output of `:highlight`.
|
Hi Rory! Sorry for the late response and thanks for the pull request. Thanks specifically for your detailed description which shows you put some thought into this and looked through the Vim documentation to find the best applicable highlighting group. Your arguments are sound and I can't find a better alternative so I've merged your pull request without changes (I just updated the docstring). Happy Vimming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used the hlgroup
'Title', but this does not accurately represent an informational message. As one can see from:help hl-Titleand the example commands it lists,'Title'is meant for section headings in long output, not a single-line message.This inapplicability was especially noticeable in my color scheme (Solarized), which shows
'Title'in an orange-red color. This color does a good job of marking titles in long output, but it makes a single-line message look like an error.Instead, I have made
#infouse no highlighting – the hlgroup'None'. I think this hlgroup most accurately represents an “informational message”. It is the same hlgroup that searches are echoed with when pressingnandN, which also seem like informational messages.While I am editing hlgroups, I also made the capitalization of their names the same as what Vim uses when you run the
:highlightcommand. This makes multi-word names a little easier to read, and aids debugging against the output of:highlight.Before:
After: