Some optimizations in StringLineGroup #399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes a few improvements to
StringLineGroup
.RemoveAt(int)
A memory leak was fixed and code duplication reduced.
ToSlice(List<LineOffset>)
First, the case where
Count == 1
has been moved before the case whereCount == 0
, simply because it is so much more common. Indeed, out of 1023 unit tests that call this method, 872 execute theCount == 1
branch, but none of them execute theCount == 0
branch.Secondly, the loop was restructured to simplify it and reduce code duplication. Using
ref var line = ref Lines[i];
, theLines
array is indexed only once per iteration.Iterator.NextChar()
_offset++;
has been moved into theif
branch, so that the_offset--;
in the else branch can be removed.