Add FileSystemWatcher support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoofx
reviewed
Dec 4, 2017
| @@ -7,6 +7,7 @@ | |||
| using System.IO; | |||
| using System.Linq; | |||
| using Zio.FileSystems; | |||
| using Zio.Watcher; | |||
There was a problem hiding this comment.
I would like to avoid a new namespace actually and the dependencies that it brings (Zio -> Zio.Watcher, Zio.FileSystems -> Zio.Watcher...etc.)
Could you move:
- the watcher interfaces (and related events) to the top root namespace along the
IFileSystem. - the helper implementations (aggregate, wrap) to FileSystems
|
Okay, I fixed all my issues with it. |
xoofx
reviewed
Dec 5, 2017
| _globalLock = new FileSystemNodeReadWriteLock(); | ||
| _dispatcher = new FileSystemEventDispatcher<Watcher>(); |
There was a problem hiding this comment.
Could we delay the creation of a _dispatcher only if we are actually using the watch API? I would prefer if we could avoid the cost of having a thread created...etc.
|
Were there any other issues with this? |
|
That's all good, sorry I'm on a business trip so a bit less available this week. Will take a bit more time next week to check things more deeply and package a new version, thanks for this PR! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current progress so far, not quite ready to merge. Still needs some documentation and unit tests.