Add EMS for FlightRadar data + fix __getitem__ function in traffic #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoolive
reviewed
Feb 3, 2025
|
|
||
| return Traffic( | ||
| df.rename(columns=dict(heading="track")) | ||
| df.rename(columns=dict(heading_x="track", heading="track")) |
There was a problem hiding this comment.
J'imagine que heading_y doit être renommé en heading non?
Pour éviter de se faire des nœuds au cerveau, je mettrai les rename différents chacun dans sa branche (cf if line 185)
xoolive
reviewed
Feb 3, 2025
| @@ -37,6 +37,7 @@ | |||
|
|
|||
| import numpy as np | |||
| import pandas as pd | |||
| import openap | |||
There was a problem hiding this comment.
ça m'embête un peu de voir ça dans ce fichier... y a pas moyen de le déplacer en mode monkey-patch dans le fichier openap.py? (dans algorithms)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flight.py: add function to check if typecode is in the database of openap
In traffic.py:
- fix getitem in order to keep the intersection when 'self' doesn't have 'flight_id'
- adapt "from_fr24" function
- add lazy evaluation for openap typecodes
In flightradar24.py: fix from_archive to be able to deal with EMS data