Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Fix asv CI #654

Merged
merged 9 commits into from
Sep 13, 2023
Merged

CHORE: Fix asv CI #654

merged 9 commits into from
Sep 13, 2023

Conversation

aresnow1
Copy link
Contributor

What do these changes do?

Fix asv benchmark CI.

Related issue number

Fixes #649

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.5.1 milestone Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #654 (21e78f0) into main (e097bd9) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   93.52%   93.42%   -0.10%     
==========================================
  Files        1025     1025              
  Lines       79283    79283              
  Branches    16434    16434              
==========================================
- Hits        74147    74071      -76     
- Misses       3449     3516      +67     
- Partials     1687     1696       +9     
Flag Coverage Δ
unittests 93.32% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

@XprobeBot XprobeBot modified the milestones: v0.5.1, v0.5.2 Aug 14, 2023
@aresnow1 aresnow1 force-pushed the chore/asv branch 2 times, most recently from 64d6c3b to e17040c Compare August 15, 2023 03:55
@XprobeBot XprobeBot modified the milestones: v0.5.2, Temp, v0.6.0, v0.6.1 Sep 8, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@aresnow1 aresnow1 marked this pull request as ready for review September 13, 2023 09:04
Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 755e120 into xorbitsai:main Sep 13, 2023
@aresnow1 aresnow1 deleted the chore/asv branch September 13, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: ASV benchmark failed recently
3 participants