Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE: Deprecate use_inf_as_na option #689

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Sep 11, 2023

What do these changes do?

Since pandas 2.1.0, mode.use_inf_as_na has been deprecated. pandas-dev/pandas#51684

  • Deprecate use_inf_as_na option

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.6.1 milestone Sep 11, 2023
@ChengjieLi28 ChengjieLi28 changed the title CHORE: Disable use_inf_as_na option CHORE: Deprecate use_inf_as_na option Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #689 (b81ae22) into main (fb8c2e0) will decrease coverage by 0.05%.
The diff coverage is 95.94%.

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   93.53%   93.49%   -0.05%     
==========================================
  Files        1025     1025              
  Lines       79379    79273     -106     
  Branches    16446    16434      -12     
==========================================
- Hits        74247    74113     -134     
- Misses       3449     3467      +18     
- Partials     1683     1693      +10     
Flag Coverage Δ
unittests 93.38% <94.59%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xorbits/_mars/config.py 81.62% <ø> (-0.07%) ⬇️
python/xorbits/_mars/dataframe/reduction/count.py 100.00% <ø> (ø)
python/xorbits/_mars/dataframe/reduction/cummax.py 100.00% <ø> (ø)
python/xorbits/_mars/dataframe/reduction/cummin.py 100.00% <ø> (ø)
...ython/xorbits/_mars/dataframe/reduction/cumprod.py 100.00% <ø> (ø)
python/xorbits/_mars/dataframe/reduction/cumsum.py 100.00% <ø> (ø)
...bits/_mars/dataframe/reduction/custom_reduction.py 100.00% <ø> (ø)
...thon/xorbits/_mars/dataframe/reduction/kurtosis.py 92.85% <ø> (-0.48%) ⬇️
python/xorbits/_mars/dataframe/reduction/max.py 100.00% <ø> (ø)
python/xorbits/_mars/dataframe/reduction/mean.py 100.00% <ø> (ø)
... and 14 more

... and 10 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit ca8e734 into xorbitsai:main Sep 12, 2023
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants