Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: ADLFS import error and docker build failed #698

Merged

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Sep 14, 2023

@XprobeBot XprobeBot added this to the v0.6.1 milestone Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #698 (da66188) into main (1876bcf) will decrease coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   93.51%   92.66%   -0.86%     
==========================================
  Files        1025     1025              
  Lines       79339    79339              
  Branches    16442    16442              
==========================================
- Hits        74193    73518     -675     
- Misses       3460     4163     +703     
+ Partials     1686     1658      -28     
Flag Coverage Δ
unittests 92.55% <ø> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 18 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 72b1e36 into xorbitsai:main Sep 15, 2023
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants